c - segfault when using strtok_r -

-

i want split string in c code:

char *search = "+" ; char *temp1; char *temp2; char *saveptr1, *saveptr2 ; int operand1 ; int operand2 ; int result ; char sumbuff [5][25]     temp1 = strtok_r(sumbuff[sumcounter-1], search, &saveptr1) ; operand2 = atoi(strtok_r(null, search, &saveptr1)); temp2 = strtok_r(temp1, ".", &saveptr2) ; operand1 = atoi(strtok_r(null, ".", &saveptr2)) ;

but when run in main code segmentation fault. , trace stack result:

#0  0x00007ffff7834517 in ?? () /lib/x86_64-linux-gnu/libc.so.6 #1  0x00007ffff7830f60 in atoi () /lib/x86_64-linux-gnu/libc.so.6 #2  0x000000000040108c in plusexec (arg=0x0) @ cm.c:112 #3  0x00007ffff7bc4182 in start_thread () /lib/x86_64-linux-gnu/libpthread.so.0 #4  0x00007ffff78f147d in clone () /lib/x86_64-linux-gnu/libc.so.6

cm.112 operand2 = atoi(...) how can correct error?

you not check return of strtok_r, can null , therefore crash atoi.

and in case:

temp2 = strtok_r(temp1, ".", &saveptr2) ; operand1 = atoi(strtok_r(null, ".", &saveptr2)) ;

...you seem looking two consecutive points? such 5.123.723? if there one, atoi receive null , coredump.

if there shouldn't 2 consecutive "."'s, that's bug.

supposing not, try:

temp2 = strtok_r(temp1, ".", &saveptr2); // e.g. 5  // if there no other token, operand1 set zero. operand1 = 0; if (temp2 != null) {     char *temp3;     temp3 = strtok_r(null, ".", &saveptr2); // e.g. 123, or null     if (temp3 != null) {         operand1 = atoi(temp3);     } }

(same approach first atoi).

depending on data format, might perhaps employ parser function return array of integers , cardinality; again, if need deal variably-dotted quantities, such 192.168.1.1 or 1.2.7.0.80.17 - otherwise needn't bother:

/**  * parses string in format 1.2343.293.777  * @param char * inputstring       input string  * @param int * vect               vector store integers  * @param size_t n                 maximum vector size  * @return size_t                  number of integers returned  */  size_t parsedottedintegers(char *inputstring, int *vect, size_t n) {     size_t = 0;     char *p;     char *save = null;     p = strtok_r(inputstring, ".", &save);     while (i < n) {         vect[i++] = atoi(p);         p = strtok_r(null, ".", &save);         if (null == p) {             return i;         }     }     // error (e.g. many parts)     return 0; }

Comments

Post a Comment

Popular posts from this blog

python - How to create jsonb index using GIN on SQLAlchemy? -

-
here's current code creating index jsonb. index("mytable_data_idx_id_key", mytable.data['id'].astext, postgresql_using='gin') but got error. sqlalchemy.exc.programmingerror: (psycopg2.programmingerror) data type text has no default operator class access method "gin" hint: must specify operator class index or define default operator class data type. [sql: "create index event_data_idx_id_key on event using gin ((data ->> 'id'))"] is there way create index on sqlalchemy? the postgresql specific sqlalchemy docs @ http://docs.sqlalchemy.org/en/latest/dialects/postgresql.html#operator-classes mention postgresql_ops dictionary provide "operator class" used postgresql, , provide example illustrating use: index('my_index', my_table.c.id, my_table.c.data, postgresql_ops={ 'data': 'text_pattern_ops', ...
Read more

PHP DOM loadHTML() method unusual warning -

-
i had following code works fine on localhost: $document = new domdocument(); $document->loadhtml($p_result); $form = $document->getelementsbytagname('form')->item(0); // code continues using $form variable after same code updated on outside server, loadhtml() failed , issued warning. warning: domdocument::loadhtml() expects parameter 1 valid path, string given in path/name/to/script.php returned null instead of object code pretty gets fatal error. note contents of $p_result absolutely same on outside server , on localhost. but why displays kind of warning , why not work? doesn't loadhtml() expects argument 1 string in first place? why method expects parameter 1 valid path ? just make clear i'm not calling loadhtmlfile() , i'm calling loadhtml() . thanks. you're affected one of php bugs . issue present in php 5.6.8 , 5.6.9. have affected php version on server, , bug-free version on localhost. the bug forbids null ...
Read more

c# - TransactionScope not rolling back although no complete() is called -

-
i'm using transactionscope rollback transaction fail bool errorreported = false; action<importerrorlog> newerrorcallback = e => { errorreported = true; errorcallback(e); }; using (var transaction = new transactionscope()) { foreach (importtaskdefinition task in taskdefinition) { loader.load(streamfile, newerrorcallback, task.destinationtable, processingtaskid); } if (!errorreported) transaction.complete(); } i'm sure there no transactionscope started ahead or after code. i'm using entity framework insert in db. regardless state of errorreported transaction never rolled in case of error. what missing ? transactionscope sets transaction.current . that's does. wants transacted must @ property. i believe ef each time connection opened reason. probably, connection open when scope installed. open connection inside of scope or enlist manually. ef has nasty "design decision": default opens ...
Read more