Is this an appropriate use of const qualifiers in C? -

-

i have simple vector implementation in c, holds array of void*. it's user take care of actual type.

i want 'promise' vector not alter contents, store data as:

struct _vector{     uint32 used;     uint32 size;     const void** arr; };

i don't know if it's considered "overdoing it" constness correctness, try maintain const correctness accessors/modifiers:

void vector_add(vector *v, const void* const elem);    void vector_set(vector *v, const uint32 idx, const void* const elem);

when return element vector, pointer user's data let user modify data being pointed to, casting away constness in internal array.

void* vector_get(const vector *v, const uint32 idx){     if ( idx >= v->used )          exitaterror("vector","array out of bounds");     return (void*)v->arr[idx]; }

instead of returning const void*, return void* instead. idea internally, want ensure not changing data being pointed to, don't care happens data outside vector.

is considered correct use of const? think it's okay declare data const in 1 place, while having mutable elsewhere. i'm unsure after reading many dogmatic articles claiming never cast away constness, , if casted away, use of const not appropriate begin with.

i want 'promise' vector not alter contents

this c. data structures not have behavior. can define vector data structure such data pointed-to cannot modified via vector, , that's have done. of course, has implications.

i don't know if it's considered "overdoing it" constness correctness, try maintain const correctness accessors/modifiers:

if you're going bother const @ all, means adhere rigorously const-correctness. otherwise, there's not point.

when return element vector, pointer user's data let user modify data being pointed to, casting away constness in internal array.

nope. you've blown it. const-correctness needs or nothing worth anything.

by casting away const, violate contract vector type makes users allowing pointed-to values modified via instance. indirectly so, sure, doesn't matter. moreover, can contribute wider violations of const correctness -- suppose, example, data entered vector const in first place. storing them in data structure ok, provide functions allow them modified (or @ least allow attempt @ that).

you consider using opaque data structure instead of const-qualifying members prevent elements being accessed directly through vectors. ultimately, though, const-correctness require separate data structures , functions vectors contain const data , contain non-const data.


Comments

Post a Comment

Popular posts from this blog

python - How to create jsonb index using GIN on SQLAlchemy? -

-
here's current code creating index jsonb. index("mytable_data_idx_id_key", mytable.data['id'].astext, postgresql_using='gin') but got error. sqlalchemy.exc.programmingerror: (psycopg2.programmingerror) data type text has no default operator class access method "gin" hint: must specify operator class index or define default operator class data type. [sql: "create index event_data_idx_id_key on event using gin ((data ->> 'id'))"] is there way create index on sqlalchemy? the postgresql specific sqlalchemy docs @ http://docs.sqlalchemy.org/en/latest/dialects/postgresql.html#operator-classes mention postgresql_ops dictionary provide "operator class" used postgresql, , provide example illustrating use: index('my_index', my_table.c.id, my_table.c.data, postgresql_ops={ 'data': 'text_pattern_ops', ...
Read more

PHP DOM loadHTML() method unusual warning -

-
i had following code works fine on localhost: $document = new domdocument(); $document->loadhtml($p_result); $form = $document->getelementsbytagname('form')->item(0); // code continues using $form variable after same code updated on outside server, loadhtml() failed , issued warning. warning: domdocument::loadhtml() expects parameter 1 valid path, string given in path/name/to/script.php returned null instead of object code pretty gets fatal error. note contents of $p_result absolutely same on outside server , on localhost. but why displays kind of warning , why not work? doesn't loadhtml() expects argument 1 string in first place? why method expects parameter 1 valid path ? just make clear i'm not calling loadhtmlfile() , i'm calling loadhtml() . thanks. you're affected one of php bugs . issue present in php 5.6.8 , 5.6.9. have affected php version on server, , bug-free version on localhost. the bug forbids null ...
Read more

c# - TransactionScope not rolling back although no complete() is called -

-
i'm using transactionscope rollback transaction fail bool errorreported = false; action<importerrorlog> newerrorcallback = e => { errorreported = true; errorcallback(e); }; using (var transaction = new transactionscope()) { foreach (importtaskdefinition task in taskdefinition) { loader.load(streamfile, newerrorcallback, task.destinationtable, processingtaskid); } if (!errorreported) transaction.complete(); } i'm sure there no transactionscope started ahead or after code. i'm using entity framework insert in db. regardless state of errorreported transaction never rolled in case of error. what missing ? transactionscope sets transaction.current . that's does. wants transacted must @ property. i believe ef each time connection opened reason. probably, connection open when scope installed. open connection inside of scope or enlist manually. ef has nasty "design decision": default opens ...
Read more