recursion - Common Lisp: Using (let) for evaluating recursive function -

-

so wrote returns maximal subset sum given list of positive integers. however, use (let) make code more efficient. know if or how possible.

(defun subset-sum1 (numbers capacity)   (subset-sum numbers capacity 0))  (defun subset-sum (numbers capacity counter)    (cond ((null numbers) counter)         ((= counter capacity) counter) ;; return if counter 'hits' capacity         ((< capacity (+ (car numbers) counter))          (subset-sum (cdr numbers) capacity counter)) ;; cdr if car branch exceeds capacity         ((<= (subset-sum (cdr numbers) capacity counter)              (subset-sum (cdr numbers) capacity (+ (car numbers) counter)))          (subset-sum (cdr numbers) capacity (+ (car numbers) counter))) ;; choose car         (t (subset-sum (cdr numbers) capacity counter)))) ;; choose cdr

the above code works fine in common lisp. but, below, because feel using let make code better. wrote goes infinite loop :( assignment introductory ai class... out novice please!

(defun subset-sum (numbers capacity counter)   (let ((exclude (subset-sum (cdr numbers) capacity counter))    (include (subset-sum (cdr numbers) capacity (+ (car numbers) counter))))      (cond ((null numbers) counter)        ((= counter capacity) counter)        ((< capacity (+ (car numbers) counter)) exclude)        ((<= exclude include) include)        (t (exclude)))))

you infinite loop because of these lines:

(defun subset-sum (numbers capacity counter)   (let ((exclude (subset-sum (cdr numbers) capacity counter))

you keep calling subset-sum recursively, , never terminates. when end of list, , numbers (), keep going, because (cdr '()) '(). handled in original checking (null numbers) (though might more idiomatic use (endp numbers)). can like:

(defun subset-sum (numbers capacity counter)   (if (endp numbers)     counter     (let ((exclude (subset-sum (cdr numbers) capacity counter))           ;...          )       (cond ; ...           ))))

Comments

Post a Comment

Popular posts from this blog

python - How to create jsonb index using GIN on SQLAlchemy? -

-
here's current code creating index jsonb. index("mytable_data_idx_id_key", mytable.data['id'].astext, postgresql_using='gin') but got error. sqlalchemy.exc.programmingerror: (psycopg2.programmingerror) data type text has no default operator class access method "gin" hint: must specify operator class index or define default operator class data type. [sql: "create index event_data_idx_id_key on event using gin ((data ->> 'id'))"] is there way create index on sqlalchemy? the postgresql specific sqlalchemy docs @ http://docs.sqlalchemy.org/en/latest/dialects/postgresql.html#operator-classes mention postgresql_ops dictionary provide "operator class" used postgresql, , provide example illustrating use: index('my_index', my_table.c.id, my_table.c.data, postgresql_ops={ 'data': 'text_pattern_ops', ...
Read more

PHP DOM loadHTML() method unusual warning -

-
i had following code works fine on localhost: $document = new domdocument(); $document->loadhtml($p_result); $form = $document->getelementsbytagname('form')->item(0); // code continues using $form variable after same code updated on outside server, loadhtml() failed , issued warning. warning: domdocument::loadhtml() expects parameter 1 valid path, string given in path/name/to/script.php returned null instead of object code pretty gets fatal error. note contents of $p_result absolutely same on outside server , on localhost. but why displays kind of warning , why not work? doesn't loadhtml() expects argument 1 string in first place? why method expects parameter 1 valid path ? just make clear i'm not calling loadhtmlfile() , i'm calling loadhtml() . thanks. you're affected one of php bugs . issue present in php 5.6.8 , 5.6.9. have affected php version on server, , bug-free version on localhost. the bug forbids null ...
Read more

c# - TransactionScope not rolling back although no complete() is called -

-
i'm using transactionscope rollback transaction fail bool errorreported = false; action<importerrorlog> newerrorcallback = e => { errorreported = true; errorcallback(e); }; using (var transaction = new transactionscope()) { foreach (importtaskdefinition task in taskdefinition) { loader.load(streamfile, newerrorcallback, task.destinationtable, processingtaskid); } if (!errorreported) transaction.complete(); } i'm sure there no transactionscope started ahead or after code. i'm using entity framework insert in db. regardless state of errorreported transaction never rolled in case of error. what missing ? transactionscope sets transaction.current . that's does. wants transacted must @ property. i believe ef each time connection opened reason. probably, connection open when scope installed. open connection inside of scope or enlist manually. ef has nasty "design decision": default opens ...
Read more