assembly - Is this an overflow, or maybe more keyboard data? -

-

i writing bootloader, , it's functionality limited printing string, copying keyboard characters screen typed. while writing routines read , write key, noticed print routine not detecting null terminator in offset (plus) 1 of double word array stores typed key. right i'm resetting terminator, thought i'd ask happening here. line in question marked ; line.

                bits    16                 org     0x7c00 start:          jmp     main  ; imported key blocking ; in: none ; out: ax bgetkey:                 pusha                 mov     ax, 0                 mov     ah, 10h                 int     16h                 mov     [.buf], ax                 popa                 mov     ax, [.buf]                 ret                 .buf    dw 0 ; end imported file  ; imported print string screen ; in:   ds->si ; out:  none prints:                 mov     ah, 0x0e                 mov     al, [si]                 cmp     al, 0                 jz      print_end                 mov     bh, 0x00                 mov     bl, 0x07                 int     0x10                 inc     si                 jmp     prints print_end:                 ret ; end imported file  main:                 mov     ax, 0x0000              ; clear ax ,                 mov     ds, ax                  ; data segment                 mov     si, welcome                 call    prints type:                 mov     si, qbuf                 call    bgetkey                 mov     [qbuf], ax                 mov     dword [qbuf + 1], 0      ; line                 call    prints                 jmp     type                 welcome db "moose os", 0x0a, 0x0d, 0x00                 newline db 0x0d, 0x0a, 0x00                 qbuf    dw 0, 0  times 0200h - 2 - ($ - $$)  db 0                 dw 0xaa55

this output of typing "abcdefg" if comment out line in question:

undesired output correct size

this desired output line uncommented:

desired output

why must reset qbuf + 1?

the problem int 16h ah=00h returns ascii character code in al , scan code in ah. mov [qbuf], ax instruction stores both in buffer, int 10h ah=0eh prints ascii characters. ends interpreting scan code stored in buffer ascii character , displays on screen accordingly.

your mov dword [qbuf + 1], 0 statement fixes problem writing 4 0 bytes after first character in qbuf. overwrites scan code stored in second byte of qbuf. sets remaining 2 bytes 0 along 1 more byte beyond end of 4 byte long qbuf. after qbuf overwritten statement, fortunately there's nothing there.

what should doing this:

call    bgetkey mov     [qbuf], al mov     byte [qbuf + 1], 0   call    prints

the second mov instruction isn't necessary in program now, byte 0. it's still idea though code doesn't break if end using qbuf else earlier in program.


Comments

Post a Comment

Popular posts from this blog

python - How to create jsonb index using GIN on SQLAlchemy? -

-
here's current code creating index jsonb. index("mytable_data_idx_id_key", mytable.data['id'].astext, postgresql_using='gin') but got error. sqlalchemy.exc.programmingerror: (psycopg2.programmingerror) data type text has no default operator class access method "gin" hint: must specify operator class index or define default operator class data type. [sql: "create index event_data_idx_id_key on event using gin ((data ->> 'id'))"] is there way create index on sqlalchemy? the postgresql specific sqlalchemy docs @ http://docs.sqlalchemy.org/en/latest/dialects/postgresql.html#operator-classes mention postgresql_ops dictionary provide "operator class" used postgresql, , provide example illustrating use: index('my_index', my_table.c.id, my_table.c.data, postgresql_ops={ 'data': 'text_pattern_ops', ...
Read more

PHP DOM loadHTML() method unusual warning -

-
i had following code works fine on localhost: $document = new domdocument(); $document->loadhtml($p_result); $form = $document->getelementsbytagname('form')->item(0); // code continues using $form variable after same code updated on outside server, loadhtml() failed , issued warning. warning: domdocument::loadhtml() expects parameter 1 valid path, string given in path/name/to/script.php returned null instead of object code pretty gets fatal error. note contents of $p_result absolutely same on outside server , on localhost. but why displays kind of warning , why not work? doesn't loadhtml() expects argument 1 string in first place? why method expects parameter 1 valid path ? just make clear i'm not calling loadhtmlfile() , i'm calling loadhtml() . thanks. you're affected one of php bugs . issue present in php 5.6.8 , 5.6.9. have affected php version on server, , bug-free version on localhost. the bug forbids null ...
Read more

c# - TransactionScope not rolling back although no complete() is called -

-
i'm using transactionscope rollback transaction fail bool errorreported = false; action<importerrorlog> newerrorcallback = e => { errorreported = true; errorcallback(e); }; using (var transaction = new transactionscope()) { foreach (importtaskdefinition task in taskdefinition) { loader.load(streamfile, newerrorcallback, task.destinationtable, processingtaskid); } if (!errorreported) transaction.complete(); } i'm sure there no transactionscope started ahead or after code. i'm using entity framework insert in db. regardless state of errorreported transaction never rolled in case of error. what missing ? transactionscope sets transaction.current . that's does. wants transacted must @ property. i believe ef each time connection opened reason. probably, connection open when scope installed. open connection inside of scope or enlist manually. ef has nasty "design decision": default opens ...
Read more