javascript - Calling socket.disconnect in a forEach loop doesn't actually call disconnect on all sockets -

-

i new javascript world. working on chat application in nodejs. have method called gracefulshutdown follows.

var gracefulshutdown = function() {     logger.info("received kill signal, shutting down gracefully.");     server.close();     logger.info('disconnecting socket.io clients');     if (object.keys(io.sockets.sockets).length == 0) process.exit();     var _map = io.sockets.sockets,         _socket;     (var _k in _map) {         if (_map.hasownproperty(_k)) {             _socket = _map[_k];             _socket.disconnect(true);         }     }     ...code here...     settimeout(function() {         logger.error("could not close connections in time, shutting down");         process.exit();     }, 10 * 1000); }

here happening in disconnect listener.the removedisconnectedclient method updates entry in db indicate removed client.

socket.on('disconnect', function() { removedisconnectedclient(socket); });

so in case disconnect event wasn't fired sockets. fired few sockets randomly array. although able fix using settimeout(fn, 0) of teammate.

i read online , understood settimeout defers execution of of code adding end of event queue. read javascript context, call stack, event loop. couldn't put of in context. don't understand why , how issue occurred. explain in detail. , best way solve or avoid them.

it hard sure without little more context rest of code in gracefulshutdown i'm surprised disconnecting of sockets @ all:

_socket = _map[ _k ]; socket.disconnect(true);

it appears assigning item _map variable _socket calling disconnect on socket, different variable. i'm guessing typo , meant call disconnect on _socket?

some of sockets might disconnecting other reasons , appearance loop disconnecting not sockets coincidence.

as far can tell code posted, socket should undefined , should getting errors trying call disconnect method on undefined.


Comments

Post a Comment

Popular posts from this blog

python - How to create jsonb index using GIN on SQLAlchemy? -

-
here's current code creating index jsonb. index("mytable_data_idx_id_key", mytable.data['id'].astext, postgresql_using='gin') but got error. sqlalchemy.exc.programmingerror: (psycopg2.programmingerror) data type text has no default operator class access method "gin" hint: must specify operator class index or define default operator class data type. [sql: "create index event_data_idx_id_key on event using gin ((data ->> 'id'))"] is there way create index on sqlalchemy? the postgresql specific sqlalchemy docs @ http://docs.sqlalchemy.org/en/latest/dialects/postgresql.html#operator-classes mention postgresql_ops dictionary provide "operator class" used postgresql, , provide example illustrating use: index('my_index', my_table.c.id, my_table.c.data, postgresql_ops={ 'data': 'text_pattern_ops', ...
Read more

PHP DOM loadHTML() method unusual warning -

-
i had following code works fine on localhost: $document = new domdocument(); $document->loadhtml($p_result); $form = $document->getelementsbytagname('form')->item(0); // code continues using $form variable after same code updated on outside server, loadhtml() failed , issued warning. warning: domdocument::loadhtml() expects parameter 1 valid path, string given in path/name/to/script.php returned null instead of object code pretty gets fatal error. note contents of $p_result absolutely same on outside server , on localhost. but why displays kind of warning , why not work? doesn't loadhtml() expects argument 1 string in first place? why method expects parameter 1 valid path ? just make clear i'm not calling loadhtmlfile() , i'm calling loadhtml() . thanks. you're affected one of php bugs . issue present in php 5.6.8 , 5.6.9. have affected php version on server, , bug-free version on localhost. the bug forbids null ...
Read more

c# - TransactionScope not rolling back although no complete() is called -

-
i'm using transactionscope rollback transaction fail bool errorreported = false; action<importerrorlog> newerrorcallback = e => { errorreported = true; errorcallback(e); }; using (var transaction = new transactionscope()) { foreach (importtaskdefinition task in taskdefinition) { loader.load(streamfile, newerrorcallback, task.destinationtable, processingtaskid); } if (!errorreported) transaction.complete(); } i'm sure there no transactionscope started ahead or after code. i'm using entity framework insert in db. regardless state of errorreported transaction never rolled in case of error. what missing ? transactionscope sets transaction.current . that's does. wants transacted must @ property. i believe ef each time connection opened reason. probably, connection open when scope installed. open connection inside of scope or enlist manually. ef has nasty "design decision": default opens ...
Read more